Only configuration cache miss when necessary #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for the contribution @TheGoesen. Please let me know if/when this is ready to be reviewed. |
Contributor
Author
|
Would appreciate an review, already enough commits on that branch |
There seems to be some kind of name clash with other things called 'ModuleInfo'.
Member
|
Thank you for digging into this and contribution this improvement @TheGoesen. Also, thank you for adding tests. The solution looks good to me. I just had some formatting and structuring remarks. I took the liberty to fix them directly while testing and reviewing the code. Would it help you if I do the next release with this change only or would you like to contribute something else on the topics discussed in the issues you opened? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently: any change to module.info will cause a gradle configuration-cache miss
Idea: use value source to filter only the changes that interest us.-> comments and changes to exports and such will no longer cause cache invalidation
... Also funky stuff on the way: the ModuleInfoCache is pretending to cache ModuleInfos, but its also not actually producing cache hits. I mostly left it like it was before